fix(build): add script to fix package json from build step #411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to octokit/plugin-retry.js#410 (comment)
Behavior
Before the change?
The released npm package is missing most of the files generated by the build step.
dist-node
,dist-types
,dist-web
... even though they are generated correctly.You can read more about my explanation in the linked issue.
After the change?
I expected npm to read the file patterns correctly so we publish all the necessary files again.
Other information
This is a mix of an issue with
npm@v9
(npm/cli#6164) and the fact we rely onpika
for the build step. Pika has been archived since April 2022 so there is nothing we can do with Pika.I'm opening a discussion to discuss what we should do: octokit/octokit.js#2403
Open questions
If we agree on this solution, we need to plan:
Additional info
Pull request checklist
Because this is kind of a temporary hack, do you think I should add tests + documentation for this?
Does this introduce a breaking change?
No
Pull request type
Because of the problems is giving to users, I'm treating it as a bug:
Type: Bug
. In terms of semantic commit, let me know if I need to changeci()
tofix()